[WSLowering] consumer release on each thread instead of master thread #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
manman-ren
reviewed
Dec 16, 2024
| remoteCTAId, false, 0); | ||
|
|
||
| auto arriveOp = builder.create<ttng::MBarrierArriveOp>( | ||
| loc, bufferEmpty, nullptr, nullptr, false, 0); | ||
| assert(op.getOperation()->hasAttr("async_task_id")); |
There was a problem hiding this comment.
I actually don't quite get this logic around remote-cta. It seems this change gets rid of the remote-cta mode.
There was a problem hiding this comment.
Yes, this gets rid of remote-cta. Do you think it is still useful? I'm not sure how it would be used.
| unsigned bufferEmptyCount = numCTAs; | ||
| builder.create<ttng::InitBarrierOp>(loc, barrierEmptyView, numCTAs); | ||
| builder.create<ttng::InitBarrierOp>(loc, barrierEmptyView, | ||
| THREADS_PER_TASK); |
There was a problem hiding this comment.
So this changes from a barrier across CTAs to a barrier within the warp group of 128 threads?
There was a problem hiding this comment.
This changes from expecting a master thread form a WG running the barrier arrival to all threads within the WG running it.
|
Nice perf win! |
manman-ren
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having each thread run the consumer release operation simplifies the logics by avoiding master thread id computation. This seems to help improve performance a bit.